chore: Uses the new selectors inside existing tests #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangevolon
force-pushed
the
alamiami/adds-find-all-components
branch
from
5e25a4b
to
2bc4260
Compare
orangevolon
force-pushed
the
alamiami/uses-new-selectors-in-existing-tests
branch
from
2e1f92f
to
e12795a
Compare
orangevolon
force-pushed
the
alamiami/adds-find-all-components
branch
from
2bc4260
to
0142e34
Compare
orangevolon
force-pushed
the
alamiami/uses-new-selectors-in-existing-tests
branch
from
e12795a
to
2ad22d0
Compare
orangevolon
force-pushed
the
alamiami/adds-find-all-components
branch
from
0142e34
to
f7fd88e
Compare
orangevolon
force-pushed
the
alamiami/uses-new-selectors-in-existing-tests
branch
from
2ad22d0
to
4e1ecb0
Compare
orangevolon
force-pushed
the
alamiami/adds-find-all-components
branch
from
2c6f204
to
369a0c5
Compare
orangevolon
requested review from
connorlanigan
and removed request for
at-susie
orangevolon
force-pushed
the
alamiami/adds-find-all-components
branch
from
95b2b79
to
dbf99f5
Compare
connorlanigan
requested changes
Nov 4, 2024
orangevolon
force-pushed
the
alamiami/adds-find-all-components
branch
from
dbf99f5
to
be2ffae
Compare
orangevolon
force-pushed
the
alamiami/uses-new-selectors-in-existing-tests
branch
from
4e1ecb0
to
d117d80
Compare
|
Thanks @connorlanigan for the great comments, all of the comments were addressed on the base PR: |
12 tasks
orangevolon
force-pushed
the
alamiami/adds-find-all-components
branch
4 times, most recently
from
a7dcd25
to
50f534a
Compare
orangevolon
force-pushed
the
alamiami/uses-new-selectors-in-existing-tests
branch
from
d117d80
to
750e5c1
Compare
orangevolon
force-pushed
the
alamiami/uses-new-selectors-in-existing-tests
branch
from
750e5c1
to
b78f452
Compare
orangevolon
changed the base branch from
alamiami/adds-find-all-components
to
feat/test-utils-project-m2
connorlanigan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the usage of the newly added selectors in this PR to the existing tests.
Depends on: #2932
Related links, issue #, if available: Test utils API improvements project
How has this been tested?
N/A
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.