Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add content permutations for container with fit height #2903

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Add content permutations for container with fit height #2903

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6245282
chore: Add content permutations for container with fit height
pan-kot Oct 19, 2024
a9cbe66
Merge branch 'main' into chore-container-fit-height-content-permutations
pan-kot Oct 22, 2024
4505a4f
Merge branch 'main' into chore-container-fit-height-content-permutations
pan-kot Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 96 additions & 6 deletions pages/container/fit-height.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,22 @@
// SPDX-License-Identifier: Apache-2.0
import React, { useContext } from 'react';

import ColumnLayout from '~components/column-layout';
import Container, { ContainerProps } from '~components/container';
import Grid from '~components/grid';
import Header from '~components/header';
import Link from '~components/link';
import SpaceBetween from '~components/space-between';
import {
Box,
ColumnLayout,
Container,
ContainerProps,
Grid,
Header,
KeyValuePairs,
Link,
SpaceBetween,
Table,
} from '~components';

import AppContext, { AppContextType } from '../app/app-context';
import { generateItems } from '../table/generate-data';
import { columnsConfig } from '../table/shared-configs';
import ScreenshotArea from '../utils/screenshot-area';

import styles from './fit-height.scss';
Expand Down Expand Up @@ -101,7 +109,89 @@ export default function () {
<div className={styles.heightLimit}>
<LargeContainer />
</div>
<h2>Content variants</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really suitable for this page?

If there is any height diff in the content above, everything below will be shifted, making this screenshot diff impossible to review

Let's stick to the principle, one use case – one page

<SpaceBetween size="m">
<Container fitHeight={true}>
<ServiceOverview />
</Container>

<Container fitHeight={true}>
<ServiceOverviewWithPadding />
</Container>

<div style={{ maxInlineSize: '500px' }}>
<Container fitHeight={true}>
<TableWithStickyScrollbar />
</Container>
</div>
</SpaceBetween>
</ScreenshotArea>
</article>
);
}

function ServiceOverview() {
return (
<KeyValuePairs
columns={4}
items={[
{
label: 'Running instances',
value: (
<Link variant="awsui-value-large" href="#" ariaLabel="Running instances (14)">
14
</Link>
),
},
{
label: 'Volumes',
value: (
<Link variant="awsui-value-large" href="#" ariaLabel="Volumes (126)">
126
</Link>
),
},
{
label: 'Security groups',
value: (
<Link variant="awsui-value-large" href="#" ariaLabel="Security groups (116)">
116
</Link>
),
},
{
label: 'Load balancers',
value: (
<Link variant="awsui-value-large" href="#" ariaLabel="Load balancers (28)">
28
</Link>
),
},
]}
/>
);
}

function ServiceOverviewWithPadding() {
return (
<Box padding={{ bottom: 'xs' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is happening here? Why is there a custom padding?

<ServiceOverview />
</Box>
);
}

const allItems = generateItems(10);
function TableWithStickyScrollbar() {
return (
<Table
variant="borderless"
header={
<Header headingTagOverride="h1" counter={`(${allItems.length})`}>
Table with sticky scrollbar
</Header>
}
columnDefinitions={columnsConfig}
items={allItems}
/>
);
}
Loading