chore: Add content permutations for container with fit height #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2903 +/- ##
========================================
Coverage 96.24% 96.24%
========================================
Files 767 767
Lines 21716 21716
Branches 7428 7028 -400
========================================
Hits 20901 20901
- Misses 762 807 +45
+ Partials 53 8 -45 ☔ View full report in Codecov by Sentry. |
just-boris
reviewed
Nov 4, 2024
|
|
||
| function ServiceOverviewWithPadding() { | ||
| return ( | ||
| <Box padding={{ bottom: 'xs' }}> |
There was a problem hiding this comment.
What is happening here? Why is there a custom padding?
| @@ -101,7 +109,89 @@ export default function () { | |||
| <div className={styles.heightLimit}> | |||
| <LargeContainer /> | |||
| </div> | |||
| <h2>Content variants</h2> | |||
There was a problem hiding this comment.
Is it really suitable for this page?
If there is any height diff in the content above, everything below will be shifted, making this screenshot diff impossible to review
Let's stick to the principle, one use case – one page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Permutations to show effects of #2864
While table sticky scrollbar is fixed, it impacts large links with underlines which can be fixed by adding extra paddings to the content itself.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.