Handle providers listed with subdomains, fix test timeouts, fix task timeouts #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilberkman
force-pushed
the
improve-host-matches
branch
from
934c6f4
to
1d32d9e
Compare
host_matches? previously would fail to match providers with URLs such as http://www.twitter.com/. Generalized the regex to handle subdomains.
neilberkman
force-pushed
the
improve-host-matches
branch
from
1d32d9e
to
4f786c6
Compare
neilberkman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host_matches?previously would fail to match providers with URLs such ashttp://www.twitter.com/. Generalized the regex to handle subdomains. Added a test for this.mix format