increase Task timeout and add test async

claytongentry · Dec 12, 2019 · 4f786c6 · 4f786c6
1 parent ef8a81c
commit 4f786c6
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/lib/furlex.ex b/lib/furlex.ex
@@ -72,7 +72,7 @@ defmodule Furlex do
   defp fetch(url, opts) do
     fetch = Task.async(Fetcher, :fetch, [url, opts])
     fetch_oembed = Task.async(Fetcher, :fetch_oembed, [url, opts])
-    yield = Task.yield_many([fetch, fetch_oembed])
+    yield = Task.yield_many([fetch, fetch_oembed], 10_000)
 
     with [fetch, fetch_oembed] <- yield,
          {_fetch, {:ok, {:ok, body, status_code}}} <- fetch,
@@ -87,7 +87,7 @@ defmodule Furlex do
     parse = &Task.async(&1, :parse, [body])
     tasks = Enum.map([Facebook, Twitter, JsonLD, HTML], parse)
 
-    with [facebook, twitter, json_ld, other] <- Task.yield_many(tasks),
+    with [facebook, twitter, json_ld, other] <- Task.yield_many(tasks, 18_000),
          {_facebook, {:ok, {:ok, facebook}}} <- facebook,
          {_twitter, {:ok, {:ok, twitter}}} <- twitter,
          {_json_ld, {:ok, {:ok, json_ld}}} <- json_ld,

diff --git a/test/furlex/parser/facebook_test.exs b/test/furlex/parser/facebook_test.exs
@@ -1,10 +1,14 @@
 defmodule Furlex.Parser.FacebookTest do
-  use ExUnit.Case
+  use ExUnit.Case, async: true
 
   alias Furlex.Parser.Facebook
 
   doctest Facebook
 
+  setup do
+    Application.put_env(:furlex, :group_keys?, true)
+  end
+
   test "parses Facebook Open Graph" do
     html =
       "<html><head><meta property=\"og:url\" " <>

diff --git a/test/furlex/parser/twitter_test.exs b/test/furlex/parser/twitter_test.exs
@@ -1,10 +1,14 @@
 defmodule Furlex.Parser.TwitterTest do
-  use ExUnit.Case
+  use ExUnit.Case, async: true
 
   alias Furlex.Parser.Twitter
 
   doctest Twitter
 
+  setup do
+    Application.put_env(:furlex, :group_keys?, true)
+  end
+
   test "parses Twitter Cards" do
     html =
       "<html><head><meta name=\"twitter:image\" " <>

diff --git a/test/furlex_test.exs b/test/furlex_test.exs
@@ -1,5 +1,5 @@
 defmodule FurlexTest do
-  use ExUnit.Case
+  use ExUnit.Case, async: true
 
   setup do
     bypass = Bypass.open()