test: skip networked tests if no connection

[bashbunni]

after all that I just deleted the networked test 😂

[bashbunni]

Hey @caarlos0 or @aymanbagabas I may need some help getting CI fixed here. It seems to be detecting github.com/charmbracelet/glow/v2 as the working directory but I'm not sure how to fix that 🤔

[ottok]

Thanks for looking into this. If you append "(Closes: #660)" in the git commit title or put "Closes: #660" anywhere in the git commit message body, it will automatically link to that issue, and also close that issue if the commit gets merged on branch "master".

[caarlos0]

Hey @caarlos0 or @aymanbagabas I may need some help getting CI fixed here. It seems to be detecting github.com/charmbracelet/glow/v2 as the working directory but I'm not sure how to fix that 🤔

I looked into this, but not sure why its failing..

FWIW we have the url tests that are also skipped due to weird network stuff... maybe worth just removing them

[ccoVeille]

This could be easier to read

Suggested change

	// Check for network issues.
	if errors.As(err, &urlErr) {
	t.Logf("Error during execution (args: %s):\n%v", v, err)
	t.Skip("Test uses network. Are you connected to the Internet?")
	} else {
	t.Errorf("Error during execution (args: %s): %T %v", v, err, err)
	}
	if buf.Len() == 0 {
	t.Errorf("Output buffer should not be empty (args: %s)", v)
	}
	// Check for network issues.
	if errors.As(err, &urlErr) {
	t.Logf("Error during execution (args: %s):\n%v", v, err)
	t.Skip("Test uses network. Are you connected to the Internet?")
	return
	}
	t.Errorf("Error during execution (args: %s): %T %v", v, err, err)
	if buf.Len() == 0 {
	t.Errorf("Output buffer should not be empty (args: %s)", v)
	}

[bashbunni]

Ah, I'm just debugging github actions right now, will be undoing these commits once I figure out what's going on 😅

[ccoVeille]

please move the variable definition aside the errors.As

[ccoVeille]

The code could be clearer

Suggested change

	// a GitHub or GitLab URL (even without the protocol):
	var dnsErr *net.DNSError
	src, err := readmeURL(arg)
	if src != nil && err == nil {
	// if there's an error, try next methods...
	return src, nil
	} else if err != nil && errors.As(err, &dnsErr) {
	// fail if there's a network error.
	return src, err
	// a GitHub or GitLab URL (even without the protocol):
	src, err := readmeURL(arg)
	if src != nil && err == nil {
	// if there's an error, try next methods...
	return src, nil
	}
	var dnsErr *net.DNSError
	if errors.As(err, &dnsErr) {
	// fail if there's a network error.
	return src, err

• The else is not needed as you use return in the if
• no need to check err != nil && errors.As(err, see https://cs.opensource.google/go/go/+/refs/tags/go1.23.4:src/errors/wrap.go;l=97-100

[ccoVeille]

if you are testing net.OpError

then you shouldn't test net.DNSError too

Here are some explanations:
https://stackoverflow.com/questions/69568234/how-do-i-work-out-what-type-of-error-my-error-is-in-go
https://haisum.github.io/2021/08/14/2021-golang-http-errors/

maybe url.Error could be enough for you

[bashbunni]

ci is failing because it's getting a forbidden response from the http.Get request.
am able to reproduce locally with non-existent repos. We don't have any types that we're wrapping around failed Get requests so these networked tests will fail if there's a non-successful call to github.

I vote to just delete TestGlowSources or maybe break it down and test the pieces that don't need a network to run properly