Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build work offline #660

Closed
ottok opened this issue Nov 29, 2024 · 1 comment · Fixed by #661
Closed

Make build work offline #660

ottok opened this issue Nov 29, 2024 · 1 comment · Fixed by #661
Labels
enhancement New feature or request

Comments

@ottok
Copy link

ottok commented Nov 29, 2024

While packaging Glow for Debian, I noticed that the build fails as it is not designed to be able to run offline.

The Debian builds run in a hermetic environment that has no external
access neither in nor out. This ensures high level of reproducibility,
stability and security. Glow should refactor these tests so that they
only run if the build is called with some special debug/test tag, or
have a pre-test that skips the tests automatically if there is no network
connection at all.

Thanks!

@ottok ottok added the enhancement New feature or request label Nov 29, 2024
@bashbunni
Copy link
Member

Hey, thanks for bringing this to our attention. I've just created a PR to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants