Use secp256k1 musig2 #405
Use secp256k1 musig2 #405
Conversation
Co-authored-by: Ekrem BAL <[email protected]>
This reverts commit d0ccc06.
* Add watchtower xonly_pk to get_params and save to db * fix clippy error * add db helper to get single xonly_pk, remove unwrap * Adjust sighash.rs and transaction.rs to remove nofn sigs from challenge page tx * Incorporate Ceyhun's feedback
* Update risc0-to-bitvm2, change anchor output * Renaming fix from circuits to header-chain
* Use global context for secp256k1 * Lint * Delete comment
* Implement kickoff_timeoout_tx * Clippy * Add kickoff_timeout_tx to sighash_stream * Change num_required_sigs
|
Are there any performance improvements? |
Looks like there isn't any noticable difference for |
| secp256k1::Message::from_digest(*msg.as_ref()) | ||
| } | ||
|
|
||
| /// Possible Musig2 modes. |
There was a problem hiding this comment.
Needs more documentation. A comprehensive documentation issue should be fine.
| // Verify the signature fails with the untweaked aggregate public key | ||
| assert!(SECP | ||
| .verify_schnorr(&final_sig, &message, &agg_pk_no_tweak) | ||
| .is_err()); | ||
| } | ||
| } |
There was a problem hiding this comment.
As I have said before, we need a test for both KeySpend and ScriptSpend for musig2 belonging to the same Taproot address. Please open a new issue if this PR will be merged directly.
|
I agree with @ozankaymak on the dependency documentation issue. We should document and track how to update when upstream is released. I've looked into rust-bitcoin, and they use 0.29.1 of secp. I upgraded it to 0.30 and opened this PR. The PR should also allow us to remove the compatibility layer when merged. For the time being, I believe we can do something like this including the comments for future reference (haven't checked syntax/validity of toml): [dependencies]
bitcoin = "0.33.0-alpha.0" # TODO: this is a major version upgrade, look into whether anything breaks on our side
secp256k1 = "0.30.0"
[patch.crates-io]
bitcoin = { git = "https://github.com/mmtftr/rust-bitcoin.git", branch = "update-secp256k1-0.30.0" } # change to rust-bitcoin/rust-bitcoin when https://github.com/rust-bitcoin/rust-bitcoin/pull/3913 is merged
# remove when a new release is made
secp256k1 = { git = "https://github.com/jlest01/rust-secp256k1", branch = "musig2-module" } # change to rust-bitcoin/rust-secp256k1 when https://github.com/rust-bitcoin/rust-secp256k1/pull/716 is merged
# remove when a new release is madeFor more info on patching, check the docs. |
|
Hold merge a bit; I am addressing the issues. |
Description
Use the active secp256k1 branch for musig2 while replacing the musig2 crate.
Key changes:
secp256k1::*tobitcoin::secp256k1::*because secp256k1 library upgraded to a breaking version and we are sticking with the older bitcoin versionutils::SECPneeds to return becausebitcoin::secp256k1doesn't feature global secp contextLinked Issues