Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track and switch to upstream versions for rust-bitcoin and secp256k1 #424

Open
4 tasks
ceyhunsen opened this issue Jan 17, 2025 · 1 comment
Open
4 tasks
Assignees

Comments

@ceyhunsen
Copy link
Member

Issue Description

We switched to secp256k1's fork that introduces musig2 bindings. It is however, conflicts with the current dependencies (#405). A PR (rust-bitcoin/rust-bitcoin#3913) has been opened to solve this issue.

Tasks

Parts of the task:

Deadline of the Issue

indefinite

@mmtftr
Copy link

mmtftr commented Jan 17, 2025

It is important to note that when rust-bitcoin/rust-bitcoin#3913 is merged, we still won't be able to upgrade due to incompatibility with rust-bitcoin = "0.33.0".

I've further tested out backporting the upgrade to rust-bitcoin = "0.32.5", but there is still more work required due to other dependencies that use musig2 (which transitively uses secp256k1 = "0.29").

This task may have more steps than outlined above due to similar circumstances as above.

I'm removing this task from the milestone due to the indefinite nature of this task.

@mmtftr mmtftr removed this from the Deposit Signature Collection milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants