chore(sidecar): rm unused dependencies #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
thedevbirb
reviewed
Jan 29, 2025
Comment on lines
+7
to
+9
| // Manually silence "rustls" crate being unused | ||
| #[allow(unused_extern_crates)] | ||
| extern crate rustls; |
There was a problem hiding this comment.
because rustls isn't used in the lib/ code, so the "unused crate" warning is triggered, but we do use it in bin/sidecar.rs, which isn't checked by this particular rule.
There was a problem hiding this comment.
Got it, related to #706
thedevbirb
approved these changes
Jan 29, 2025
merklefruit
force-pushed
the
nico/chore/rm-unused-deps
branch
from
5e71ea3 to
fd04dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some unused dependencies in bolt_sidecar.
Added a library attribute to warn us in the future.
Dependencies removed: