Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all reth types #752

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Jan 29, 2025

  • We can get away with alloy::consensus::PooledTransaction instead of reth_primitives::TransactionSigned
  • Similarly, BlockBody, SealedBlock, SealedHeader from reth can all be avoided with alloy::consensus::Block!

We don't have any reth types left after this. Upstack PR #753 removes them from Cargo.toml!

@merklefruit
Copy link
Collaborator Author

merklefruit commented Jan 29, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@merklefruit merklefruit changed the title chore: minimize reth dependencies used chore: minimize reth types used Jan 29, 2025
@mempirate
Copy link
Contributor

They seem to have some sealed types: https://docs.rs/alloy/latest/alloy/?search=Sealed

@merklefruit
Copy link
Collaborator Author

merklefruit commented Jan 29, 2025

They seem to have some sealed types: docs.rs/alloy/latest/alloy?search=Sealed

taking a look :)

edit: yeah it was pretty simple, we can just use alloy::consensus::Block!

@merklefruit merklefruit changed the title chore: minimize reth types used chore: remove all reth types Jan 29, 2025
@merklefruit merklefruit requested a review from mempirate January 29, 2025 13:54
@merklefruit
Copy link
Collaborator Author

Tested in the devnet, and was able to self-build blocks.

@merklefruit merklefruit merged commit 8f349ee into unstable Jan 30, 2025
3 checks passed
@merklefruit merklefruit deleted the nico/chore/minimize-reth-deps branch January 30, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants