feat: add contract bindings #38
Merged
+2,686
−254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
This was referenced Jan 28, 2025
Merged
mempirate
reviewed
Jan 28, 2025
registry/src/chainio/mod.rs
Outdated
There was a problem hiding this comment.
Do you like the ABI workflow more than just the contract interface in the macros? I guess it's less error prone
There was a problem hiding this comment.
I like it because there's a single source of truth and no copy pasting interfaces manually, otherwise no strong opinion
|
I like this, can we add a |
mempirate
approved these changes
Jan 29, 2025
registry/Cargo.toml
Outdated
| @@ -35,7 +35,7 @@ axum = "0.8.1" | |||
| sqlx = { version = "0.8", features = ["runtime-tokio", "tls-native-tls", "postgres", "chrono"] } | |||
|
|
|||
| # ethereum | |||
| alloy = { version = "0.9.1", features = ["consensus", "rpc-types", "reqwest"] } | |||
| alloy = { version = "0.9.1", features = ["full", "rpc-types", "reqwest"] } | |||
There was a problem hiding this comment.
Why do we need full? I think it's good practice to only pull in what you need
There was a problem hiding this comment.
Good call, 7668af1
thedevbirb
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABIs can be refreshed by using the
just abigencommand