feat: impl get_lookahead, minor refactoring #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
merklefruit
commented
Jan 28, 2025
•
merklefruit
commented
- impl get_lookahead action on the registry
- minor refactoring of the bin entrypoint
📚
|
Merged
mempirate
requested changes
Jan 28, 2025
registry/src/registry.rs
Outdated
| // 10936976: { validator_pubkey: 0x1234, operator: 0x5678, gas_limit: 1000000, rpc_endpoint: https://rpc.example.com } | ||
| // 10936977: { validator_pubkey: 0x9214, operator: 0x5678, gas_limit: 1000000, rpc_endpoint: https://rpc.example.com } | ||
| // 10936978: { validator_pubkey: 0x1983, operator: 0x5678, gas_limit: 1000000, rpc_endpoint: https://rpc.example.com } | ||
| let mut lookahead = HashMap::new(); |
There was a problem hiding this comment.
Nit but can we create a type alias in primitives, to be used in openAPI spec?
type Lookahead = HashMap<u64, Entry>There was a problem hiding this comment.
it's already like that, I guess I could use Lookahead::new() instead to make it more clear though
mempirate
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.