Run tests in nix release build

default.nix

@@ -22,7 +22,7 @@ let
 
   haskellPackages = import ./nix/default.nix {
     inherit pkgs haskell src;
-    inherit cardano-http-bridge cardano-sl-node jormungandr;
+    inherit cardano-http-bridge cardano-sl-node jmPkgs;
     inherit (iohkLib.nix-tools) iohk-extras iohk-module;
   };
 

lib/core-integration/cardano-wallet-core-integration.cabal

@@ -56,6 +56,7 @@ library
     , text
     , text-class
     , time
+    , QuickCheck
   hs-source-dirs:
       src
   exposed-modules:
@@ -76,3 +77,4 @@ library
       Test.Integration.Scenario.CLI.Port
       Test.Integration.Scenario.CLI.Transactions
       Test.Integration.Scenario.CLI.Wallets
+      Cardano.Wallet.TransactionSpecShared

lib/core/src/Cardano/Wallet/Api/Server.hs

@@ -347,14 +347,21 @@ data ListenError
 
 ioToListenError :: HostPreference -> Listen -> IOException -> Maybe ListenError
 ioToListenError hostPreference portOpt e
+    -- A socket is already listening on that address and port
     | isAlreadyInUseError e =
         Just (ListenErrorAddressAlreadyInUse (listenPort portOpt))
+    -- Usually caused by trying to listen on a privileged port
     | isPermissionError e =
         Just ListenErrorOperationNotPermitted
+    -- Bad hostname
     | isDoesNotExistError e =
         Just (ListenErrorHostDoesNotExist hostPreference)
+    -- Address is valid, but can't be used for listening -- Linux
     | show (ioeGetErrorType e) == "invalid argument" =
         Just (ListenErrorInvalidAddress hostPreference)
+    -- Address is valid, but can't be used for listening -- Darwin
+    | show (ioeGetErrorType e) == "unsupported operation" =
+        Just (ListenErrorInvalidAddress hostPreference)
     | otherwise =
         Nothing
   where

lib/core/test/unit/Cardano/Wallet/Api/TypesSpec.hs

@@ -105,6 +105,8 @@ import Control.Lens
     ( Lens', at, (^.) )
 import Control.Monad
     ( replicateM )
+import Control.Monad.IO.Class
+    ( liftIO )
 import Crypto.Hash
     ( hash )
 import Data.Aeson
@@ -163,6 +165,8 @@ import Servant
     )
 import Servant.Swagger.Test
     ( validateEveryToJSON )
+import System.Environment
+    ( lookupEnv )
 import Test.Aeson.GenericSpecs
     ( GoldenDirectoryOption (CustomDirectoryName)
     , Proxy (Proxy)
@@ -1019,8 +1023,12 @@ specification :: Swagger
 specification =
     unsafeDecode bytes
   where
-    bytes = $(makeRelativeToProject "../../specifications/api/swagger.yaml"
-        >>= embedFile)
+    bytes = $(
+        let swaggerYaml = "../../specifications/api/swagger.yaml"
+        in liftIO (lookupEnv "SWAGGER_YAML") >>=
+        maybe (makeRelativeToProject swaggerYaml) pure >>=
+        embedFile
+        )
     unsafeDecode =
         either (error . (msg <>) . show) Prelude.id . Yaml.decodeEither'
     msg = "Whoops! Failed to parse or find the api specification document: "

lib/http-bridge/cardano-wallet-http-bridge.cabal

@@ -125,6 +125,7 @@ test-suite unit
     , bytestring
     , cardano-crypto
     , cardano-wallet-core
+    , cardano-wallet-core-integration
     , cardano-wallet-http-bridge
     , cborg
     , containers
@@ -153,7 +154,6 @@ test-suite unit
       Cardano.Wallet.HttpBridge.Primitive.AddressDerivation.SequentialSpec
       Cardano.Wallet.HttpBridge.Primitive.TypesSpec
       Cardano.Wallet.HttpBridge.TransactionSpec
-      Cardano.Wallet.TransactionSpecShared
       Data.PackfileSpec
       Servant.Extra.ContentTypesSpec
 
@@ -199,6 +199,8 @@ test-suite http-bridge-integration
     , text-class
     , time
     , transformers
+  build-tools:
+      cardano-wallet-http-bridge
   type:
      exitcode-stdio-1.0
   hs-source-dirs:

lib/http-bridge/test/integration/Test/Integration/HttpBridge/Scenario/CLI/Launcher.hs

@@ -37,16 +37,11 @@ import System.IO
 import System.IO.Temp
     ( withSystemTempDirectory, withSystemTempFile )
 import System.Process
-    ( createProcess
-    , proc
-    , terminateProcess
-    , waitForProcess
-    , withCreateProcess
-    )
+    ( terminateProcess, withCreateProcess )
 import Test.Hspec
     ( Spec, describe, it, pendingWith )
 import Test.Hspec.Expectations.Lifted
-    ( shouldBe, shouldReturn )
+    ( shouldBe )
 import Test.Integration.Framework.DSL
     ( KnownCommand (..)
     , cardanoWalletCLI
@@ -66,7 +61,7 @@ import Test.Integration.Framework.DSL
 import Test.Integration.Framework.TestData
     ( versionLine )
 import Test.Utils.Ports
-    ( findPort, randomUnusedTCPPorts )
+    ( findPort )
 
 import qualified Data.Text.IO as TIO
 
@@ -156,26 +151,6 @@ spec = do
                     TIO.hGetContents o >>= TIO.putStrLn
                     TIO.hGetContents e >>= TIO.putStrLn
 
-    describe "DaedalusIPC" $ do
-        let defaultArgs nodePort =
-                [ commandName @t, "launch", "--node-port", show nodePort ]
-        let tests =
-                [ (const ["--random-port"], " [SERIAL]")
-                , (\fixedPort -> ["--port", fixedPort], "")
-                , (const [], " [SERIAL]")
-                ]
-        forM_ tests $ \(args, tag) -> do
-            let title = "should reply with the port when asked "
-                    <> show (args "FIXED") <> tag
-            it title $ withTempDir $ \d -> do
-                [fixedPort, nodePort] <- randomUnusedTCPPorts 2
-                let filepath = "test/integration/js/mock-daedalus.js"
-                let stateDir = ["--state-dir", d]
-                let scriptArgs = concat
-                        [defaultArgs nodePort, args (show fixedPort), stateDir]
-                (_, _, _, ph) <- createProcess (proc filepath scriptArgs)
-                waitForProcess ph `shouldReturn` ExitSuccess
-
     describe "LOGGING - cardano-wallet launch logging [SERIAL]" $ do
         it "LOGGING - Launch can log --verbose" $ withTempDir $ \d -> do
             pendingWith "See 'LAUNCH - Restoration workers restart'"

lib/http-bridge/test/integration/Test/Integration/HttpBridge/Scenario/CLI/Server.hs

@@ -27,16 +27,11 @@ import System.Exit
 import System.IO.Temp
     ( withSystemTempDirectory )
 import System.Process
-    ( createProcess
-    , proc
-    , terminateProcess
-    , waitForProcess
-    , withCreateProcess
-    )
+    ( terminateProcess, withCreateProcess )
 import Test.Hspec
     ( Spec, SpecWith, describe, it )
 import Test.Hspec.Expectations.Lifted
-    ( shouldBe, shouldContain, shouldReturn )
+    ( shouldBe, shouldContain )
 import Test.Integration.Framework.DSL
     ( Context (..)
     , KnownCommand (..)
@@ -49,8 +44,6 @@ import Test.Integration.Framework.DSL
     )
 import Test.Integration.Framework.TestData
     ( versionLine )
-import Test.Utils.Ports
-    ( findPort )
 
 spec :: forall t. KnownCommand t => SpecWith (Context t)
 spec = do
@@ -82,29 +75,6 @@ spec = do
             err `shouldBe` mempty
             c `shouldBe` ExitFailure 1
 
-    describe "DaedalusIPC" $ do
-        let defaultArgs nodePort =
-                [ commandName @t
-                , "serve"
-                , "--node-port"
-                , show nodePort
-                ]
-
-        let filepath = "test/integration/js/mock-daedalus.js"
-
-        it "Should reply with the port --random" $ \ctx -> do
-            let scriptArgs = defaultArgs (ctx ^. typed @(Port "node"))
-                    ++ ["--random-port"]
-            (_, _, _, ph) <- createProcess (proc filepath scriptArgs)
-            waitForProcess ph `shouldReturn` ExitSuccess
-
-        it "Should reply with the port --random" $ \ctx -> do
-            walletPort <- findPort
-            let scriptArgs = defaultArgs (ctx ^. typed @(Port "node"))
-                    ++ ["--port", show walletPort]
-            (_, _, _, ph) <- createProcess (proc filepath scriptArgs)
-            waitForProcess ph `shouldReturn` ExitSuccess
-
     describe "LOGGING - cardano-wallet serve logging" $ do
         it "LOGGING - Launch can log --verbose" $ \ctx -> do
             let args = ["serve", "--random-port", "--verbose"

lib/jormungandr/cardano-wallet-jormungandr.cabal

@@ -134,6 +134,7 @@ test-suite unit
     , bytestring
     , cardano-crypto
     , cardano-wallet-core
+    , cardano-wallet-core-integration
     , cardano-wallet-jormungandr
     , containers
     , directory
@@ -165,7 +166,6 @@ test-suite unit
       Cardano.Wallet.Jormungandr.EnvironmentSpec
       Cardano.Wallet.Jormungandr.NetworkSpec
       Cardano.Wallet.Jormungandr.TransactionSpec
-      Cardano.Wallet.TransactionSpecShared
 
 test-suite integration
   default-language:
@@ -227,6 +227,9 @@ test-suite integration
     , transformers
     , warp
     , yaml
+  build-tools:
+      nodejs
+    , cardano-wallet-jormungandr
   type:
      exitcode-stdio-1.0
   hs-source-dirs:

lib/launcher/test/unit/Cardano/LauncherSpec.hs

@@ -40,35 +40,35 @@ spec = do
 
     it "1st process exits with 0, others are cancelled" $ do
         let commands =
-              [ Command "./test/data/once.sh" ["0"] (pure ()) Inherit
-              , Command "./test/data/forever.sh" [] (pure ()) Inherit
+              [ mockCommand 0 (pure ())
+              , foreverCommand
               ]
         (ProcessHasExited name code) <- launch nullTracer commands
         name `shouldBe` cmdName (commands !! 0)
         code `shouldBe` ExitSuccess
 
     it "2nd process exits with 0, others are cancelled" $ do
         let commands =
-              [ Command "./test/data/forever.sh" [] (pure ()) Inherit
-              , Command "./test/data/once.sh" ["0"] (pure ()) Inherit
+              [ foreverCommand
+              , mockCommand 0 (pure ())
               ]
         (ProcessHasExited name code) <- launch nullTracer commands
         name `shouldBe` cmdName (commands !! 1)
         code `shouldBe` ExitSuccess
 
     it "1st process exits with 14, others are cancelled" $ do
         let commands =
-              [ Command "./test/data/once.sh" ["14"] (pure ()) Inherit
-              , Command "./test/data/forever.sh" [] (pure ()) Inherit
+              [ mockCommand 14 (pure ())
+              , foreverCommand
               ]
         (ProcessHasExited name code) <- launch nullTracer commands
         name `shouldBe` cmdName (commands !! 0)
         code `shouldBe` (ExitFailure 14)
 
     it "2nd process exits with 14, others are cancelled" $ do
         let commands =
-              [ Command "./test/data/forever.sh" [] (pure ()) Inherit
-              , Command "./test/data/once.sh" ["14"] (pure ()) Inherit
+              [ foreverCommand
+              , mockCommand 14 (pure ())
               ]
         (ProcessHasExited name code) <- launch nullTracer commands
         name `shouldBe` cmdName (commands !! 1)
@@ -78,7 +78,7 @@ spec = do
         mvar <- newEmptyMVar
         let before = putMVar mvar "executed"
         let commands =
-                [ Command "./test/data/once.sh" ["0"] before Inherit
+                [ mockCommand 0 before
                 ]
         (ProcessHasExited _ code) <- launch nullTracer commands
         code `shouldBe` ExitSuccess
@@ -90,3 +90,12 @@ spec = do
                 ]
         ProcessDidNotStart name _exc <- launch nullTracer commands
         name `shouldBe` "foobar"
+
+-- | A command that will run for a short time then exit with the given status.
+mockCommand :: Int -> IO () -> Command
+mockCommand exitStatus before =
+    Command "sh" ["-c", "sleep 1; exit " ++ show exitStatus] before Inherit
+
+-- | A command that will run for longer than the other commands.
+foreverCommand :: Command
+foreverCommand = Command "sleep" ["30"] (pure ()) Inherit