Run tests in nix release build #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/703/nix-run-tests
branch
from
a0981e4
to
475160e
Compare
rvl
force-pushed
the
rvl/703/nix-run-tests
branch
from
475160e
to
ec527b5
Compare
rvl
force-pushed
the
rvl/703/nix-run-tests
branch
from
ec527b5
to
50da6e6
Compare
|
Here is a screenshot of the startup error I was getting before.
Currently the windows cross build is not working. It was working before. We need to update the Haskell.nix version to fix it. |
rvl
force-pushed
the
rvl/703/nix-run-tests
branch
3 times, most recently
from
b346c52
to
680afa3
Compare
rvl
changed the title
rvl
force-pushed
the
rvl/703/nix-run-tests
branch
from
680afa3
to
f472328
Compare
rvl
force-pushed
the
rvl/703/nix-run-tests
branch
from
f472328
to
8390131
Compare
Fixes the Nix build. Each package should have an independent source tree.
Changed this for the nix build. Alternatively, we could have provided coreutils and bash so that the scripts can run. But I think it's neater without external shell scripts.
rvl
force-pushed
the
rvl/703/nix-run-tests
branch
from
3210c9e
to
d25adc6
Compare
This was referenced Oct 23, 2019
KtorZ
approved these changes
Oct 23, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 24, 2019
766: Run tests in nix release build r=rvl a=rvl Relates to #703 and #704. Base branch is #864 - this should be merged first. # Overview - [x] This enables test suites under the Nix build. - [x] Fixes test cases that used symlinks. - [x] `Cardano.Wallet.Api.TypesSpec` is trying to access a file `/build/core/../../specifications/api/swagger.yaml` which is outside of its package. - [x] Some tests in `cardano-wallet-jormungandr:test:integration` required `jcli`. - [x] Some tests in `cardano-wallet-jormungandr:test:integration` required a writable home directory. - [x] In LauncherSpec the test scripts used `/usr/bin/env`, which is not in the nix-build sandbox, so i made the tests not need external scripts. - [x] Adds macOS tests to the Hydra required jobs. [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-766) # Comments - Symlinks/references to files in other packages won't work with the nix build because when it builds it copies the package source tree to `/build` and builds from there. # Remaining failures These windows-specific failures can be fixed in the next PR. - [ ] `x86_64-pc-mingw32.tests.cardano-wallet-jormungandr.unit.x86_64-linux` expects UTF-8 encoding, but this is not the encoding that Wine is using. - [ ] Windows cross build got broken. We now require a fix for Haskell.nix. - [ ] `cardano-wallet-jormungandr.exe` would fail on windows at startup with ``` NUL: openFile: does not exist (No such file or directory) ``` Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #703 and #704.
Base branch is #864 - this should be merged first.
Overview
Cardano.Wallet.Api.TypesSpecis trying to access a file/build/core/../../specifications/api/swagger.yamlwhich is outside of its package.cardano-wallet-jormungandr:test:integrationrequiredjcli.cardano-wallet-jormungandr:test:integrationrequired a writable home directory./usr/bin/env, which is not in the nix-build sandbox, so i made the tests not need external scripts.Hydra jobset
Comments
/buildand builds from there.Remaining failures
These windows-specific failures can be fixed in the next PR.
x86_64-pc-mingw32.tests.cardano-wallet-jormungandr.unit.x86_64-linuxexpects UTF-8 encoding, but this is not the encoding that Wine is using.cardano-wallet-jormungandr.exewould fail on windows at startup with