Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): add 'pip check' linter #1951

Merged
merged 18 commits into from
Oct 21, 2024
Merged

feat(linter): add 'pip check' linter #1951

merged 18 commits into from
Oct 21, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Oct 9, 2024

This linter runs 'pip check' on the venv of the resulting charm and warns if the virtual environment is inconsistent.

@lengau
feat(linter): add 'pip check' linter
4845c12 
This linter runs 'pip check' on the venv of the resulting charm and
warns if the virtual environment is inconsistent.
@bepri bepri marked this pull request as ready for review October 16, 2024 12:33
@bepri bepri linked an issue Oct 16, 2024 that may be closed by this pull request
pip check linter #1889
Closed
@bepri bepri self-assigned this Oct 16, 2024
@bepri bepri requested review from a team and removed request for mr-cal and mattculler October 16, 2024 14:25
lengau
lengau commented Oct 16, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@bepri bepri requested a review from mr-cal October 16, 2024 20:21
mr-cal
mr-cal reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Some of these open-ended questions may need @lengau's input, so don't feel like you must have an answer :)

tests/unit/test_linters.py Show resolved Hide resolved
charmcraft/linters.py Show resolved Hide resolved
charmcraft/linters.py Outdated Show resolved Hide resolved
@mr-cal mr-cal requested a review from a team October 16, 2024 20:43
@bepri bepri requested a review from mr-cal October 17, 2024 19:12
mr-cal
mr-cal approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

If I ever leave a pedantic/opinion comment, it's your call to take or leave it.

charmcraft/linters.py Outdated Show resolved Hide resolved
tigarmo
tigarmo approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@bepri bepri enabled auto-merge October 18, 2024 15:21
@lengau lengau disabled auto-merge October 21, 2024 14:38
@lengau lengau merged commit 3a09483 into main Oct 21, 2024
21 of 23 checks passed
@lengau lengau deleted the work/1889/CRAFT-3369 branch October 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bepri bepri bepri left review comments

@tigarmo tigarmo tigarmo approved these changes

@mr-cal mr-cal mr-cal approved these changes

@dariuszd21 dariuszd21 Awaiting requested review from dariuszd21

Assignees

@bepri bepri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip check linter
4 participants
@lengau @tigarmo @bepri @mr-cal