-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): add 'pip check' linter #1951
Conversation
This linter runs 'pip check' on the venv of the resulting charm and warns if the virtual environment is inconsistent.
a5d1d3c
to
4845c12
Compare
81ead06
to
1692246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
Some of these open-ended questions may need @lengau's input, so don't feel like you must have an answer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
If I ever leave a pedantic/opinion comment, it's your call to take or leave it.
Co-authored-by: Callahan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice :)
This linter runs 'pip check' on the venv of the resulting charm and warns if the virtual environment is inconsistent.