Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip check linter #1889

Closed
lengau opened this issue Sep 10, 2024 · 3 comments · Fixed by #1951
Closed

pip check linter #1889

lengau opened this issue Sep 10, 2024 · 3 comments · Fixed by #1951
Labels
Enhancement New feature or request triaged

Comments

@lengau
Copy link
Collaborator

lengau commented Sep 10, 2024

What needs to get done

Create a linter that checks that the venv is consistent using pip check

Why it needs to get done

With strict dependencies, we want to give people a build-time error about missing dependencies rather than runtime.

@lengau lengau added Enhancement New feature or request triaged labels Sep 10, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3369.

This message was autogenerated

@sergiusens
Copy link
Collaborator

Is this a Craft Application or Charmcraft analyze feature?

@lengau
Copy link
Collaborator Author

lengau commented Sep 19, 2024

@sergiusens this would be a charmcraft linter (both in analyse and at the end of packing). I'm not sure how we could feasibly do this in craft-application.

@bepri bepri linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants