Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC72] Update frontend for backend Spring Boot #4753

Merged
merged 80 commits into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
5206bb5
attempt at getting demo-rfc72 localdb tests to run
inodb Oct 9, 2023
e74ac6f
update keycloak cmd
inodb Oct 9, 2023
74737a0
fix properties location in localdb test
inodb Oct 9, 2023
0350ca6
add spring datasource props
inodb Oct 9, 2023
20c7883
try to address missing WEB-INF classpath
inodb Oct 12, 2023
f28d5f7
fix typo
inodb Oct 12, 2023
f5b8344
Update db_content_fingerprint.sh
JREastonMarks Nov 7, 2023
3005bbf
:wrench: Update to support latest security changes from Backend
haynescd Nov 8, 2023
4c4495b
Update to support localdb test with new rfc72 setup
haynescd Nov 14, 2023
fa49ffd
Update setup.sh
haynescd Nov 14, 2023
2455138
Remove .init.sh for config file
haynescd Nov 14, 2023
88aeb95
Force to demo-rfc72
haynescd Nov 15, 2023
1589ddc
match cna chart colors with oncoprint and adjust label colors accordi…
7xuanlu Oct 11, 2023
91ec7ef
Publish
Oct 11, 2023
2c4a183
Genie portal timeline: tweak track ordering for assessment tracks
alisman Oct 11, 2023
df613a3
RFC69 : survival chart with landmark events and hazard ratio (#4740)
TJMKuijpers Oct 16, 2023
260d9d1
Add download data and PDF option (#4757)
TJMKuijpers Oct 19, 2023
a50f48a
fix link to MKS Impact study agreement
alisman Oct 20, 2023
7bba099
Patient timeline: Make sure sample acquisition track always appears a…
alisman Oct 20, 2023
335a2fa
Fix SVG download (prevent embedding of css)
alisman Oct 25, 2023
bf2e376
Publish
Oct 26, 2023
0d8daf3
Refactor to allow pie and table charts to download both full and summ…
alisman Oct 25, 2023
3b777e6
Publish
Oct 30, 2023
8e41827
Update API clients
alisman Oct 30, 2023
b5f3517
Publish
Oct 30, 2023
026d25d
Update screenshots
alisman Nov 1, 2023
97cd09d
Fix incorrect oncokb data and cancer type label used in mutations tab…
gblaih Nov 3, 2023
afb4f01
Study view: fix comparison session generation from study view bin cha…
alisman Nov 2, 2023
76138e9
Clinical attribute types with priority of zero should not appear by d…
alisman Nov 7, 2023
9173be9
Update screenshots with civic disabled
alisman Nov 8, 2023
e12ae71
Add subgroup alteration percentages to oncoprint when gaps are turned on
alisman Oct 10, 2023
6fead93
add end to end tests for gap percentages
alisman Nov 8, 2023
e8384ee
Update screenshots
alisman Nov 14, 2023
8d4eb70
Update screenshots
alisman Nov 14, 2023
9d2aae7
Publish
Nov 14, 2023
aa0bead
Fix endless loop of gene validation update that prevents update to ge…
alisman Nov 14, 2023
9565082
Change gene add behavior to improve user experience
alisman Nov 8, 2023
08df019
Force frontend e2e to run against beta
haynescd Nov 15, 2023
319690d
Update dockerfile to copy db-scripts
haynescd Nov 15, 2023
8803db2
[RFC77] Filter buttons on the landing page study search menu (#4721)
TJMKuijpers Nov 17, 2023
009bdd7
Restore asterisks in oncoprint track percentage labels
alisman Nov 15, 2023
c0be5c7
Publish
Nov 20, 2023
376b920
Fix spec import
alisman Nov 20, 2023
e8ea61e
oncoprint color config for mutations testing
Aug 16, 2023
ef8cabd
add color config for all alterations
Aug 18, 2023
fbc06ef
use default colors as computed and refactor
Sep 7, 2023
fd2e5e9
added color config for clinical tracks
Sep 29, 2023
7a04670
add toggle to select between white/grey glyph backgrounds and refacto…
Oct 5, 2023
a52aa43
add white background for glyphs query to url
Oct 6, 2023
9acdf33
add button to reset colors and fix crash when going into oncoprinter
Oct 10, 2023
f73c4e4
move color menu to modal under individual track menu
Oct 12, 2023
758602a
address review comments
Oct 30, 2023
4318bed
add persistence through local storage
Nov 6, 2023
8dbbbb4
edit color config menu layout and adress review comment
Nov 6, 2023
03cca8a
add e2e tests and screenshots
Nov 8, 2023
78d4f7e
change modal layout
Nov 9, 2023
f22e60b
fix flaky color configuration tests
Nov 9, 2023
bfbea36
update screenshots
Nov 20, 2023
da420a8
Add datadog logging to frontend
alisman Nov 27, 2023
b248bd5
Merge branch 'master' into demo-rfc72
haynescd Nov 28, 2023
965e514
Update property file for localdb test
haynescd Nov 30, 2023
1ae1dd7
Update custombranch yml to include keycloak
haynescd Dec 4, 2023
efd3799
Update cbioportal_custom.yml to pass certs
haynescd Dec 4, 2023
84b1944
update certs to be on classpath
haynescd Dec 5, 2023
91607e7
Remove custom cbioportal when loading studys
haynescd Dec 5, 2023
fc0248b
Update api-docs call
JREastonMarks Dec 5, 2023
951282d
Remove api-docs
JREastonMarks Dec 5, 2023
ba3fec0
Change api to swagger
JREastonMarks Dec 5, 2023
b57919a
Update prettierIgnore to ignore cert and genset file
haynescd Dec 5, 2023
6902f7a
Update fetchAPI
JREastonMarks Dec 5, 2023
1354246
Update .prettierIgnore
haynescd Dec 6, 2023
4b70fc0
Add OpenApi3 to Swagger 2 conversion
haynescd Dec 10, 2023
5067b54
Update Frontend Code to match newly generated API
haynescd Dec 10, 2023
86b5fd6
Update spec to use correct Enum type
haynescd Dec 10, 2023
923a804
Fix unit test ClinicalDataUtils.spec.ts
haynescd Dec 10, 2023
9a509b6
Update timeouts for flaky tests
haynescd Dec 12, 2023
f88664a
:wrench: Add configuration for Study Help Button
haynescd Dec 12, 2023
f621439
Merge remote-tracking branch 'origin/master' into demo-rfc72
haynescd Dec 13, 2023
39cd4aa
Fix Logout URL
haynescd Dec 15, 2023
280f3e7
Merge remote-tracking branch 'origin/master' into demo-rfc72
haynescd Dec 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion end-to-end-test/local/docker_compose/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ cd $E2E_WORKSPACE
git clone --depth 1 --branch $BACKEND_BRANCH --single-branch https://github.com/$BACKEND_PROJECT_USERNAME/cbioportal.git
cd cbioportal
mvn -DskipTests clean install
unzip portal/target/cbioportal*.war -d portal/target/war-exploded

cd $PWD

Expand Down
2 changes: 1 addition & 1 deletion end-to-end-test/local/docker_compose/cbioportal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: '3'
services:
cbioportal:
volumes:
- $TEST_HOME/runtime-config/portal.properties:/cbioportal/portal.properties:ro
- $TEST_HOME/runtime-config/portal.properties:/cbioportal-webapp/portal.properties:ro
- $E2E_WORKSPACE/portalInfo:/portalInfo

volumes:
Expand Down
8 changes: 4 additions & 4 deletions end-to-end-test/local/docker_compose/keycloak.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ version: '3'

services:
cbioportal:
image: cbioportal/cbioportal:demo-rfc72
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove later, this is a hack b/c it's no longer picking up the env/custom.sh BACKEND parameter

volumes:
- $TEST_HOME/docker_compose/keycloak/samlKeystore.jks:/cbioportal-webapp/WEB-INF/classes/samlKeystore.jks:ro
- $E2E_WORKSPACE/keycloak/idp-metadata.xml:/cbioportal-webapp/WEB-INF/classes/client-tailored-saml-idp-metadata.xml:ro
command: /bin/sh -c "java -Xms2g -Xmx4g -Dauthenticate=saml -Dsession.service.url=http://cbioportal-session:5000/api/sessions/my_portal/ -jar webapp-runner.jar -AmaxHttpHeaderSize=16384 -AconnectionTimeout=20000 --enable-compression /cbioportal-webapp"

- $TEST_HOME/docker_compose/keycloak/samlKeystore.jks:/cbioportal-webapp/samlKeystore.jks:ro
- $E2E_WORKSPACE/keycloak/idp-metadata.xml:/cbioportal-webapp/client-tailored-saml-idp-metadata.xml:ro
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WEB-INF folder disappeared in spring boot

command: /bin/sh -c "rm -rf /cbioportal-webapp/lib/servlet-api-2.5.jar && java -Xms2g -Xmx4g -Ddat.method=none -Dmultithread.core_pool_size=1 -Dauthenticate=saml -Dspring.security.saml2.relyingparty.registration.cbio-idp.identityprovider.metadata-uri=classpath://saml2-idp-metadata.xml -Dsession.service.url=http://cbioportal-session:5000/api/sessions/my_portal/ -cp '/cbioportal-webapp:/cbioportal-webapp/lib/*' org.cbioportal.PortalApplication"
keycloak:
networks:
- cbio-net
Expand Down
3 changes: 3 additions & 0 deletions end-to-end-test/local/docker_compose/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ mkdir -p $E2E_WORKSPACE/keycloak
cd $E2E_WORKSPACE
git clone https://github.com/cBioPortal/cbioportal-docker-compose.git
cd cbioportal-docker-compose
#TODO: temporarily use docker compose for demo-rfc72
# https://github.com/cBioPortal/cbioportal-docker-compose/pull/23
git checkout demo-rfc72

# update keycloak config with permissions for test studies
config_json="$(cat $TEST_HOME/docker_compose/keycloak/keycloak-config.json)"
Expand Down
6 changes: 6 additions & 0 deletions end-to-end-test/local/runtime-config/portal.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
app.name=cbioportal

# database
spring.datasource.url=jdbc:mysql://cbioportal-database:3306/cbioportal?useSSL=false&allowPublicKeyRetrieval=true
spring.datasource.username=cbio_user
spring.datasource.password=somepassword
spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver
spring.jpa.database-platform=org.hibernate.dialect.MySQL5InnoDBDialect
spring.datasource.driver-class-name=com.mysql.jdbc.Driver
db.user=cbio_user
db.password=somepassword
db.driver=com.mysql.jdbc.Driver
Expand Down
1 change: 1 addition & 0 deletions env/custom.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
#export CBIOPORTAL_URL="http://localhost:8081"
#export GENOME_NEXUS_URL="https://www.genomenexus.org"
BACKEND=cbioportal:demo-rfc72
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inodb did this work? i tried this but coun't get it to work (in another PR). I mean, couldn't even get it to checkout the right branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this did not work, but updating image: directly does work