[RFC72] Update frontend for backend Spring Boot #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
commented
Oct 9, 2023
| @@ -2,11 +2,11 @@ version: '3' | |||
|
|
|||
| services: | |||
| cbioportal: | |||
| image: cbioportal/cbioportal:demo-rfc72 | |||
There was a problem hiding this comment.
need to remove later, this is a hack b/c it's no longer picking up the env/custom.sh BACKEND parameter
33 tasks
alisman
reviewed
Oct 10, 2023
env/custom.sh
Outdated
| @@ -1,2 +1,3 @@ | |||
| #export CBIOPORTAL_URL="http://localhost:8081" | |||
| #export GENOME_NEXUS_URL="https://www.genomenexus.org" | |||
| BACKEND=cbioportal:demo-rfc72 | |||
There was a problem hiding this comment.
@inodb did this work? i tried this but coun't get it to work (in another PR). I mean, couldn't even get it to checkout the right branch
There was a problem hiding this comment.
this did not work, but updating image: directly does work
inodb
commented
Oct 12, 2023
Comment on lines
7
to
8
| - $TEST_HOME/docker_compose/keycloak/samlKeystore.jks:/cbioportal-webapp/samlKeystore.jks:ro | ||
| - $E2E_WORKSPACE/keycloak/idp-metadata.xml:/cbioportal-webapp/client-tailored-saml-idp-metadata.xml:ro |
There was a problem hiding this comment.
WEB-INF folder disappeared in spring boot
haynescd
force-pushed
the
demo-rfc72
branch
4 times, most recently
from
5c56fd3 to
049116a
Compare
#4750) * match cna chart colors with oncoprint and adjust label colors according to slice brightness * fix end to end tests on study view page * update pie charts @computed to @autoBind --------- Co-authored-by: Qi-Xuan Lu <[email protected]>
Add the group information as label below chart landmark line functionality Dynamic calculation of groups for axis Implement hazard ratio show hazard ratio between every group Remove hazard ratio warning when feature flag is disabled Removed feature flag for survival chart
Update the call to api-docs
Remove api-docs from urls
inodb
changed the title
inodb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cBioPortal/cbioportal#10356
Only merge once the backend is approved&merged: cBioPortal/cbioportal#10425