-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to check struct and array missingness #738
Open
klaricch
wants to merge
26
commits into
main
Choose a base branch
from
kl/validity_checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
48e3140
add missingness fucntions
klaricch af258a8
small edit
klaricch 9845c7c
small edit
klaricch e842d04
Apply suggestions from code review
klaricch 288d39e
PR suggestions
klaricch 67cdae5
add unfurl_array_annotations
klaricch f545e47
Update gnomad/assessment/validity_checks.py
klaricch 03a0e6a
Update gnomad/assessment/validity_checks.py
klaricch 42d38da
PR suggestions
klaricch 5783d70
check for fully missing arrays
klaricch 25f26fe
small edit
klaricch c43a5c4
add test_validity_checks
klaricch c9ba932
black
klaricch 1c82c69
small edit
klaricch d034378
black
klaricch 7a87d90
isort
klaricch b95e2de
small edits
klaricch 2153896
small edit
klaricch 9d05626
black
klaricch dc49e1e
small edit
klaricch c369ce5
black
klaricch f466c2e
Apply suggestions from code review
klaricch 67ab7cb
PR suggestions
klaricch ced3784
PR suggestions
klaricch 425702d
small edit
klaricch e9061fc
tset
klaricch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this faster than running
.flatten()
and then checking for missingness on the flattened struct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also just noticed this: https://hail.is/docs/0.2/hail.expr.StructExpression.html#hail.expr.StructExpression.summarize -- do you know if this is too slow to run at scale? I guess it might be annoying to read through too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the summarize adds a lot of other things that we don't need
and not sure if this is any faster, i could just flatten them as well and then check missingness