Add functions to check struct and array missingness #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch-kr
requested changes
Dec 6, 2024
| struct_expr: hl.expr.StructExpression, prefix: str = "" | ||
| ) -> dict: | ||
| """ | ||
| Recursively check the fraction of missing values of all fields within a StructExpression. |
There was a problem hiding this comment.
is this faster than running .flatten() and then checking for missingness on the flattened struct?
There was a problem hiding this comment.
I also just noticed this: https://hail.is/docs/0.2/hail.expr.StructExpression.html#hail.expr.StructExpression.summarize -- do you know if this is too slow to run at scale? I guess it might be annoying to read through too
There was a problem hiding this comment.
yeah the summarize adds a lot of other things that we don't need
and not sure if this is any faster, i could just flatten them as well and then check missingness
Co-authored-by: Katherine Chao <[email protected]>
ch-kr
reviewed
Dec 9, 2024
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
|
will start adding tests |
ch-kr
reviewed
Dec 12, 2024
ch-kr
reviewed
Dec 18, 2024
Co-authored-by: Katherine Chao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.