Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 200 Error handling #3288

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

alexgromero
Copy link
Contributor

@alexgromero alexgromero commented Oct 23, 2024

This PR updates the S3 200 Errors implementation (#3276) to address bugs introduced in payload operations.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit; otherwise looks good. Thanks @alexgromero!

botocore/handlers.py Outdated Show resolved Hide resolved
Co-authored-by: Nate Prewitt <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (0e229ae) to head (afd0021).
Report is 132 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3288   +/-   ##
========================================
  Coverage    93.17%   93.18%           
========================================
  Files           66       66           
  Lines        14339    14368   +29     
========================================
+ Hits         13361    13389   +28     
- Misses         978      979    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgromero alexgromero merged commit dc02db5 into boto:develop Oct 23, 2024
40 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Oct 23, 2024
* release-1.35.47:
  Bumping version to 1.35.47
  Update endpoints model
  Update to latest models
  Fix S3 200 Error handling (#3288)
hswong3i pushed a commit to alvistack/boto-botocore that referenced this pull request Oct 24, 2024
@alexgromero alexgromero deleted the update-200-errors branch October 30, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants