GetBucketPolicy broken by PR #3276

[odormond]

Describe the bug

Trying to get a bucket policy consistently fails with fake error 500 Internal Server Error.

The issue comes from PR #3276 forcibly trying to parse the body as an XML document and failing as it's a JSON document and then considering it _looks_like_special_case_error due to this line:

botocore/botocore/handlers.py

Line 180 in bab77d8

return True

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

The bucket policy document is returned successfully.

Current Behavior

An error is ClientError is raised.

Reproduction Steps

With adequate permissions, and a bucket with some policy configured, run:

aws --debug s3api get-bucket-policy --bucket test-bucket-with-policy

Possible Solution

Don't feed a response body whose header says Content-Type: application/json to an XML parser.

Additional Information/Context

No response

SDK version used

1.35.45

Environment details (OS name and version, etc.)

Ubuntu 22.04.5 LTS

[tim-finnigan]

Thanks for reporting, the team in looking into this issue and will post updates here.

[tim-finnigan]

Linking PR including fix: #3288, which should be released soon.

[mukitmomin]

@tim-finnigan just confirming, is this fix to be released in v1.35.46 or the following release? I'm seeing the same error with botocore=v1.35.46 right now.

[nateprewitt]

@mukitmomin the fix for GetBucketPolicy should be available in our next release. You can track releases in our tags or via PyPI. We'll also post here once it's available.

[tim-finnigan]

@mukitmomin - release 1.35.47 is now out, please update your version of boto3/botocore in order to have access to this fix.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.