Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event stream regression #3285

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

alexgromero
Copy link
Contributor

@alexgromero alexgromero commented Oct 22, 2024

This PR addresses a regression in the SelectObjectContent functionality that was introduced in Botocore 1.35.45. This issue was identified in issue #3284.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (0e229ae) to head (051cdfb).
Report is 127 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3285   +/-   ##
========================================
  Coverage    93.17%   93.18%           
========================================
  Files           66       66           
  Lines        14339    14358   +19     
========================================
+ Hits         13361    13379   +18     
- Misses         978      979    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgromero alexgromero merged commit 33fd15d into boto:develop Oct 22, 2024
40 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Oct 22, 2024
* release-1.35.46:
  Bumping version to 1.35.46
  Update endpoints model
  Update to latest models
  Fix event stream regression (#3285)
hswong3i pushed a commit to alvistack/boto-botocore that referenced this pull request Oct 23, 2024
alexgromero added a commit to alexgromero/botocore that referenced this pull request Oct 23, 2024
@alexgromero alexgromero deleted the test-200-errors branch October 23, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants