Skip to content

Commit

Permalink
Fix event stream regression (#3285)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexgromero authored Oct 22, 2024
1 parent b5ed2ef commit 33fd15d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-s3-44124.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "``s3``",
"description": "Fixed SelectObjectContent regression from `#3284 <https://github.com/boto/botocore/issues/3284>`__."
}
6 changes: 5 additions & 1 deletion botocore/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,11 @@ def document_expires_shape(section, event_name, **kwargs):
def _handle_200_error(operation_model, response_dict, **kwargs):
# S3 can return a 200 response with an error embedded in the body.
# Convert the 200 to a 500 for retry resolution in ``_update_status_code``.
if not response_dict or operation_model.has_streaming_output:
if (
not response_dict
or operation_model.has_streaming_output
or operation_model.has_event_stream_output
):
# Operations with streaming response blobs are excluded as they
# can't be reliably distinguished from an S3 error.
return
Expand Down

0 comments on commit 33fd15d

Please sign in to comment.