-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove swap from python ci #1714
Conversation
How do you know the swap space is not needed? Is there any analysis or memory dump showing this? When we added the swap space, it was because the compilation would take too much memory, causing the VM to be killed. We have empirical evidence of that, however there is no evidence in this PR to the contrary. |
Because I compile on the ci without it, and the ci don't crash on gcc out of memory. |
This is not a very convincing argument. I can make the opposite claim, which means nothing without evidence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this, we can revert this if it causes any issues.
This is valid argument, because I show on this PR how I remove the swap and it still running and compiling and running the tests. What is really happen, when you did your measurements tests linux ci was with low memory for gtsam with tbb compilation. |
Thank you for approving. I agree. If we have issues we can later revet / fix them. |
Sorry but this is not a valid argument. You may have just gotten lucky and the CI passed for you this time without the root cause being addressed.
This is conjecture. Can you please provide evidence for this? Going forward I won't be approving PRs that make hand-wavy claims without the necessary discussion and evidence to back it up. |
Remove swap from python ci
It not needed for the ci.
Also may fix the hang problem.