-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support msvc 2022 along 2019 #1715
Support msvc 2022 along 2019 #1715
Conversation
I thought you had fixed the hanging CI issue? |
I say probably will fix. |
That's not quite what you said here: #1714 (comment) Again, please don't make claims without evidence. I have less reason to trust your changes now. |
As you can see from my first msg on the PR:
Also you can see from other recent PRs here on gtsam that they are green and not red as they used to be. You don't have to trust on my good changes. You can test them as long as you want. And if this was bad change you already would reverted my change without talking to me, as you write on the PR. |
On this comment I was talking about the swap that is not needed, because I show you how gcc not crash lacking the memory. |
The other PRs are green because I've been re-running the CI until the test passes. I also have not reverted your changes, I don't understand why you're accusing me of that. |
I don't accused you that you reverted my changes. And if you can please review this PR. |
a6e32cc
to
ffb6268
Compare
ffb6268
to
1a021ee
Compare
d42b51e
to
fa321bf
Compare
fa321bf
to
5a81dc0
Compare
Fix #1642
Support msvc 2022 along 2019: