-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: validate "contribution checks" wf by introducing extra errors #155
Conversation
|
Contribution Guidelines checksThe content of the files modified by this Pull Request doesn't match the Contribution Guidelines. Please update the following files. ⏸️ Attributes validationSome attributes are missing in the following files:
⛔ Forbidden pattern validationSome patterns are forbidden in the following files:
|
…129) Ensure that the commit of the PR branch is used when the action is triggered by `pull_request_target` and not the commit of the base branch. Improve debug logs and remove duplication. ### Notes This should fix what is described in bonitasoft/bonita-labs-doc#153 (comment). This PR has been tested with bonitasoft/bonita-labs-doc#155 Covers bonitasoft/bonita-documentation-site#685
ℹ️ After the merge of #158, we see that the reusable workflow is using the "antora action" with better support for "pull_request_target" events. |
"Contribution Checks" correctly detects all errors in 0a9ec57 and correctly create/update the PR comments. |
All tests have been successfully completed. So closing this PR. |
Covers bonitasoft/bonita-documentation-site#685