Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better support pull_request_target in "antora checker" action #129

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Apr 15, 2024

Ensure that the commit of the PR branch is used when the action is triggered by pull_request_target and not the commit of the base branch.
Improve debug logs and remove duplication.

Notes

This should fix what is described in bonitasoft/bonita-labs-doc#153 (comment).
This PR has been tested with bonitasoft/bonita-labs-doc#155
Covers bonitasoft/bonita-documentation-site#685

@tbouffard tbouffard added the enhancement New feature or request label Apr 15, 2024
Copy link
Collaborator

@benjaminParisel benjaminParisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@benjaminParisel benjaminParisel merged commit 73bef82 into main Apr 16, 2024
4 checks passed
@benjaminParisel benjaminParisel deleted the feat/pr-antora-checker_better_support_pr-target branch April 16, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants