Disable taps while swiping between feeds #7312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix home screen * fix profile, list, starter pack screens * fix search screen * fix notification screen * fix hashtag screen * fix topic screen
|
Thanks for looking into this. I agree it’s very annoying and we need to get some fix in. Would you be open to looking into the underlying cause? We really should fix it at the pager level. If we know what the fix is, patching it in would be fine. |
|
I tried, but I don't really know enough about gesture stuff to make a proper fix, sorry. I'll look into it some more but I'm not very confident |
|
I narrowed it down to a small repro case: callstack/react-native-pager-view#960 |
|
Posted a native fix on #7459. Seems to work quite well! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been encountering this behavior on mobile, where sometimes (a lot of the times!) swiping horizontally to go from feed A to feed B registers a tap on feed A. So it would move to the next feed and after a small delay it would unexpectedly expand a post or an image from the previous feed, which makes for a very annoying experience:
video.mp4
This is most likely a bug with react-native-pager-view, callstack/react-native-pager-view#776.
As a workaround, I made it so that while the page is being dragged, touch events are captured by the corresponding view, so hopefully no presses are triggered further down. It seems to work, and I cannot reproduce the behavior anymore, except in the case where one is at the first/last page and swipes away from the edge, like so:
video2.mp4