[Android] Try to disambiguate taps from swipes #7448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
capture-swipes - social-app PR #7448
Render
Destroyed
|
mozzius
approved these changes
Jan 15, 2025
gaearon
added a commit
that referenced
this pull request
Jan 17, 2025
* [Android] Fix taps triggering while swiping * Revert "[Android] Try to disambiguate taps from swipes (#7448)" This reverts commit 96054f4. * Update patch to match callstack/react-native-pager-view#961 * Make it symmetrical --------- Co-authored-by: Dan Abramov <[email protected]>
gaearon
added a commit
that referenced
this pull request
Jan 20, 2025
* Bump pager * Revert "[Android] Try to disambiguate taps from swipes (#7448)" This reverts commit 96054f4. --------- Co-authored-by: gpp-0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hackfix for callstack/react-native-pager-view#960.
Alternative to #7312 but doesn't require copy paste and also seems to work more reliably.
Comments explain how it works.
Will need some testing.