Fix symbol resolution for malloc_type functions on macOS Sequoia #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
cpp_fix_sequoia
branch
3 times, most recently
from
c2bd704
to
055f3c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
- Coverage 92.96% 92.91% -0.06%
==========================================
Files 95 95
Lines 11655 11655
Branches 406 406
==========================================
- Hits 10835 10829 -6
- Misses 820 826 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
force-pushed
the
cpp_fix_sequoia
branch
4 times, most recently
from
c96540e
to
529af2a
Compare
This commit addresses an issue with symbol resolution for malloc_type functions on the latest macOS Sequoia. The problem arises due to changes in how these functions are named in the dynamic symbol table of the system libraries that are part of the linker cache like the ones that contain the C++ runtime. This fix ensures that Memray correctly intercepts and tracks allocations made by malloc_type functions, fixing tracking allocations in the C++ runtime and other system libraries on macOS Sequoia. Signed-off-by: Pablo Galindo <[email protected]>
pablogsal
force-pushed
the
cpp_fix_sequoia
branch
4 times, most recently
from
f8a39ac
to
ed8d053
Compare
There a bug either in the genhtml utility in Alpine or in coverage.py that trips over some categories that are in the dump file. We don't use these files in CI for anything so for now we should skip the html generation. Signed-off-by: Pablo Galindo <[email protected]>
pablogsal
force-pushed
the
cpp_fix_sequoia
branch
from
ed8d053
to
1a8d38d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue with symbol resolution for malloc_type
functions on the latest macOS Sequoia. The problem arises due to changes
in how these functions are named in the dynamic symbol table of the
system libraries that are part of the linker cache like the ones that
contain the C++ runtime.
This fix ensures that Memray correctly intercepts and tracks allocations
made by malloc_type functions, fixing tracking allocations in the C++
runtime and other system libraries on macOS Sequoia.