Skip to content

Commit

Permalink
Skip coverage html generation in Alpine
Browse files Browse the repository at this point in the history
There a bug either in the genhtml utility in Alpine or in coverage.py
that trips over some categories that are in the dump file. We don't use
these files in CI for anything so for now we should skip the html
generation.

Signed-off-by: Pablo Galindo <[email protected]>
  • Loading branch information
pablogsal committed Oct 30, 2024
1 parent e89d434 commit beea5cd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ jobs:
container:
image: alpine
options: --cap-add=SYS_PTRACE
env:
# Coverage is kind of broken in Alpine
SKIP_COVERAGE_HTML: 1
steps:
- uses: actions/checkout@v4
- name: Set up dependencies
Expand Down
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ pycoverage: ## Run the test suite, with Python code coverage
--cov-append $(PYTEST_ARGS) \
tests
$(PYTHON) -m coverage lcov -i -o pycoverage.lcov
genhtml *coverage.lcov --branch-coverage --output-directory memray-coverage $(GENHTMLOPTS)
if [ -z "$$SKIP_COVERAGE_HTML" ]; then \
genhtml *coverage.lcov --branch-coverage --output-directory memray-coverage $(GENHTMLOPTS); \
fi

.PHONY: valgrind
valgrind: ## Run valgrind, with the correct configuration
Expand Down
1 change: 1 addition & 0 deletions news/693.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug that was causing tracking of runtime libraries that are part of the linker cache not work in macOS 15.

0 comments on commit beea5cd

Please sign in to comment.