Fix test suite #21
Merged
Fix test suite #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not send project_id when requesting /health - /health endpoint is intended to be accessible without secret - switching from decommissioned testnet to preview testnet
robinboening
force-pushed
the
fix_tests
branch
from
d7804f6 to
096f11c
Compare
reflecting current API behaviour, namely response status 400 for invalid asset parameter.
- reflecting current API behaviour (response code 400 for malformatted params)
robinboening
commented
Feb 23, 2023
| @@ -17,7 +17,7 @@ class << self | |||
| # @param project_id [String] the project_id to pass to url in headers. | |||
| # @param params [Hash] params to add to request, allowed :order, :page, :count, :from, :to. | |||
| # @return [Hash] formatted result with status and body keys. | |||
| def get_response(url, project_id, params = {}) | |||
| def get_response(url, project_id = nil, params = {}) | |||
There was a problem hiding this comment.
making project_id optional as /health doesn't need to provide the secret
This was referenced Feb 23, 2023
|
Thank you so much @robinboening! Feel free to add it to workflows, it was never there, just on one testing branch. |
|
Fixed the pending specs as well. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of this PR
project_idoptional as /health endpoint doesn't need to provide the secret