Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/health endpoint not requiring authentication #19

Closed
robinboening opened this issue Feb 23, 2023 · 3 comments
Closed

/health endpoint not requiring authentication #19

robinboening opened this issue Feb 23, 2023 · 3 comments

Comments

@robinboening
Copy link
Collaborator

I was running the tests today and saw quite a bunch of them failing. Besides some other issues I found that the test suite expects the /health endpoint to only be accessible with a valid project_id. It is currently accessible without a secret though.

What is the intended behaviour?
@mmahut
Copy link
Member

mmahut commented Feb 23, 2023

It should be accessible without a token too.

@robinboening
Copy link
Collaborator Author

I can change the tests to reflect that.

@robinboening
Copy link
Collaborator Author

fixed by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmahut @robinboening