Fix Vulkan renderer on wayland

[belegdol]

This fixes the outstanding problems mentioned in #2416. I do not really know C++ so tips how to determine wl_surface dynamically are welcome.
In order to test this, --with-sdl --with-wayland needs to be added to makefile line 116.

[belegdol]

To be precise: we need a way of passing the wmi.info.wl.surface from

bgfx/examples/common/entry/entry_sdl.cpp

Line 58 in 506da04

struct wl_surface* surface = wmi.info.wl.surface;

to
https://github.com/belegdol/bgfx/blob/1628329a12fdaa74ccfd6eeca5b176a1b7ddf689/src/renderer_vk.cpp#L6782
I do not know how to do that, the existing structures appear to only be able to pass display and window handles but not the surface one. For the proof-of-concept I inspected the value with the debugger and hardcoded it. It works in gdb only.

[belegdol]

Would something like this be acceptable?

[bkaradzic]

There won't be Wayland surface... PR needs to work as it would be with X, Windows, etc. nothing special won't be added for Wayland.

[belegdol]

Turns out it was simpler than originally thought.

[bkaradzic]

Much better... what is setting this WL_EGL_PLATFORM?

[belegdol]

It is set by genie.lua:

bgfx/scripts/genie.lua

Lines 207 to 209 in 8b6a6bd

	if _OPTIONS["with-wayland"] then
	defines { "WL_EGL_PLATFORM=1" }
	end

[bkaradzic]

@belegdol Check this: https://github.com/libsdl-org/SDL/pull/9345 (intentionally in code quotes to not notify the issue, since it has nothing to do with bgfx, just notifying you about the issue).

[belegdol]

@belegdol Check this: https://github.com/libsdl-org/SDL/pull/9345 (intentionally in code quotes to not notify the issue, since it has nothing to do with bgfx, just notifying you about the issue).

Thanks for the info, this is a bit disappointing. In any case, slow is better than crashing in my opinion. Additionally, for cases like mame - which motivated me to submit this PR in the first place - getting every last bit of GPU performance is not that critical. mame runs fast enough on my machines at least.

[bkaradzic]

In any case, slow is better than crashing in my opinion.

Yes. Anyhow, the point of notifying you is just to keep you informed. No action needed on bgfx.