Allow simultaneous X11 and Wayland support

[belegdol]

XWayland detection is a hack currently. Feedback is welcome how to do this in a less ugly way

[belegdol]

XWayland "detection" fails for mame for example so it definitely needs to be improved. Suggestions are welcome.

[bkaradzic]

Actually I was thinking about this, and maybe would be worth adding type of handle inside PlatformData. To specify which handle is passed.

[belegdol]

I think this would be ideal. Anything else is going to be a workaround to some extent. Do you have something like my original attempt in #3143 in mind?

[bkaradzic]

Not original because you were adding new field for specific type of window handle. What I'm thinking just one enum to identify pointer type. Since all platforms have one type it would be default (on Linux default would mean X11) and if you passing Wayland handle on Linux you would specify with enum.

struct NativeWindowHandleType
{
     enum Enum
     {
           Default = 0,
           Wayland,
           
           Count
     };
};

[belegdol]

Something like this? If so, I will add the code to other examples.

[belegdol]

I have added the code to the remaining entries and the remaining examples.

[bkaradzic]

Submit another PR where you use BX_UNUSED(_handle) on code like this:

	bgfx::NativeWindowHandleType::Enum getNativeWindowHandleType(WindowHandle _handle)
	{
		return bgfx::NativeWindowHandleType::Default;
	}

[belegdol]

Submit another PR where you use BX_UNUSED(_handle) on code like this:

	bgfx::NativeWindowHandleType::Enum getNativeWindowHandleType(WindowHandle _handle)
	{
		return bgfx::NativeWindowHandleType::Default;
	}

I just tried but this results in SIGILL:

	bgfx::NativeWindowHandleType::Enum getNativeWindowHandleType(WindowHandle _handle)
	{
		BX_UNUSED(_handle);
	}

[bkaradzic]

BX_UNUSED is just for handle, you don't need to change anything else...

[bkaradzic]

	bgfx::NativeWindowHandleType::Enum getNativeWindowHandleType(WindowHandle _handle)
	{
	        BX_UNUSED(_handle); <--- prevents warnings about unused argument...
		return bgfx::NativeWindowHandleType::Default;
	}

[bkaradzic]

See: cbfea75