Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baip-0002.md #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

baip-0002.md #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions baip-0002.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
BAIP: 0002
Title: Reform of loopholes in feed price mechanism
Authors: cn-vote [email protected]
Status: Draft
Status: Accepted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree. Many pull request review comments await responses: #9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree. Many pull request review comments await responses: #9

Active, any questions here can be answered

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not true, the majority of the BAIP2 file is not available to be commented on in the 'files changed' section. Answer the questions in #9 than dodge them - if they hold no validity then surely it'd be simple to respond to them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content of BAIP002 is very complete.
In fact, this plan has been discussed in the forum for more than a month.
We should not stay in endless discussions without doing anything of practical significance.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content of BAIP002 is very complete.

I disagree, at the very least there are multiple grammar errors.

We should not stay in endless discussions without doing anything of practical significance.

Then address comments in the pull request review process than disregard BAIP processes. Being unable to directly defend ones own work is concerning & indicative of poor quality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grctest would you like to create a new pull request to correct the grammar errors so we can go forward? I guess it's too hard for the original author(s) since his/their English skill is not as good as yours.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the direct threat of legal action by the author, no.

My original pull request comments are still there if anyone's interested.

Type: Consensus
Created: 2019-10-22
Created: 2019-11-7


# Abstract
Expand Down