Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baip-0002.md #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

baip-0002.md #15

wants to merge 1 commit into from

Conversation

wenhuadream
Copy link
Contributor

BAIP: 0002
Title: Reform of loopholes in feed price mechanism
Authors: cn-vote  [email protected]
Status: Accepted
Type: Consensus 
Created: 2019-10-22

Abstract

This BAIP defines reforms to the current feed price mechanism vulnerability. The specific program is: The feed price is the highest between the current price and the two-day moving average price .

Motivation

After the failure of BSIP42, the current feed price mechanism has major loopholes and serious negatives, many cex exchanges use our vulnerability to maliciously short,which seriously damaged the ecological balance, which caused us to suffer many unnecessary losses and hindered the development of the entire ecology.
When the vulnerability has been expanded to be intolerable, in an emergency, the passage and execution of BSIP76 has temporarily blocked the expansion of the vulnerability. However, the current feed price mechanism is still in urgent need of reform.

Rational

"The feed price is the highest between the current price and the two-day moving average price ".
This BAIP does not conflict with the previous consensus on the feed price of all the communities. The feed provider continue to collect the feed price according to the original community consensus, and the community consensus on the protection of the black swan(BSIP58) and the minimum feed price is continued(BSIP76).
This BAIP only requires the introduction of the abstract described in the feed price script, which is
"The feed price is the highest between the current price and the two-day moving average price ".

Specifications

Implementing measures

If (current price >  two-day moving average price) {
  feed price = current price;
}
Else{
  feed price = two-day moving average price;
}

Noun explanation

  • Current price : The real-time feed price of the current feed price mechanism before the reform.
  • Two-day moving average price : two-day moving average price =( current price (1) + current price (2) + current price ( 3) ...+ current price (n) )/n.
    • n is the sampling frequency, which is 48 times, that is, n = 48*m; m is positive: m = 1, 2, 3....
    • current price (k) is the current price at the time of sampling. The current price (1) is the
      current price at this moment. The current price (n) is the current price at the time of 48 hours ago.
    • Sampling interval (in hours): sampling interval = 48 / n = 48 / (48 * m). That is: m = 1, two- day moving average price every hour to sample once,;m = 2, two-day moving average price half an hour to sample once, And so on.

supplementary explanation

To decide whether to reform of loopholes in feed price mechanism, 2 poll worker proposals will be created for voting:

  • Poll-BAIP**- Reform of loopholes in feed price mechanism.
  • Poll-BAIP**-Not reform of loopholes in feed price mechanism.

If the voting confirm the change, committee will announce the change at least 3 days before the change is implemented by feed provider.

Summary for Shareholders

This program is simple and effective, and can prevent malicious short-selling or increase malicious short-selling costs to a certain extent.

Discussion

bitshares/bsips#244

See Also

https://bitsharestalk.org/index.php?topic=29698.0
https://bitsharestalk.org/index.php?topic=29699.0
https://bitsharestalk.org/index.php?topic=29635.0
https://bitsharestalk.org/index.php?topic=28418.0
https://bitsharestalk.org/index.php?topic=29684.0
https://bitsharestalk.org/index.php?topic=29687.0

Copyright

This document is placed in the public domain.

@@ -1,9 +1,9 @@
BAIP: 0002
Title: Reform of loopholes in feed price mechanism
Authors: cn-vote [email protected]
Status: Draft
Status: Accepted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree. Many pull request review comments await responses: #9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree. Many pull request review comments await responses: #9

Active, any questions here can be answered

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not true, the majority of the BAIP2 file is not available to be commented on in the 'files changed' section. Answer the questions in #9 than dodge them - if they hold no validity then surely it'd be simple to respond to them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content of BAIP002 is very complete.
In fact, this plan has been discussed in the forum for more than a month.
We should not stay in endless discussions without doing anything of practical significance.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content of BAIP002 is very complete.

I disagree, at the very least there are multiple grammar errors.

We should not stay in endless discussions without doing anything of practical significance.

Then address comments in the pull request review process than disregard BAIP processes. Being unable to directly defend ones own work is concerning & indicative of poor quality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grctest would you like to create a new pull request to correct the grammar errors so we can go forward? I guess it's too hard for the original author(s) since his/their English skill is not as good as yours.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the direct threat of legal action by the author, no.

My original pull request comments are still there if anyone's interested.

@malcolmjmr
Copy link

After the failure of BSIP42, the current feed price mechanism has major loopholes and serious negatives, many cex exchanges use our vulnerability to maliciously short,which seriously damaged the ecological balance, which caused us to suffer many unnecessary losses and hindered the development of the entire ecology.

What examples do you have of malicious shorts?

@grctest
Copy link

grctest commented Mar 11, 2020

This BAIP failed to prevent the price feed threshold workaround from BSIP76 from needing to be activated for a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants