do not allow edge attribtues with same type id for trapi #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
biothings/biothings_explorer#891
Previously, if a edge had mutliple TRAPI records, the last TRAPI record would decide the edge-attributes, which meant no duplicates (and no merging behavior).
With the SemmedDB sentences PR (#219), it was required in that situation to merge multiple (suporting publication) edge-attributes from the different records composing an edge.
Here, I have changed the behavior for all attributes (except the ones used in SemmedDB sentences) to a behavior where if multiple TRAPI records have edge attributes with the same attribute_type_id, only the first one will be taken.