-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated edge-attributes #891
Comments
When I try replicating the subquery BTE would have sent MolePro, I don't get duplicated edge-attributes from the MolePro edge. But I do get different KL/AT values: Saved response MolePro-direct-1.json Query
Matching edge
|
When I try replicating the subquery BTE would have sent Drug Approvals, I don't get duplicated edge-attributes. Saved response DAKP-1.json Query
Matching Edge
|
FYI: I'm seeing some duplicate/missing KL-AT validation issues occurring in Aragorn and Improving Agent as well. However, they appear to have had these issues before this weekend: It's hard to track down/review the edges in ARAX-UI. May need to recreate by querying those ARAs directly. But also maybe don't need to keep digging here. |
Investigation so farMostly copied from Slack DMs with @tokebe Jackson
MeDoesn't seem to be from biothings/bte_trapi_query_graph_handler#220. I locally reset module to |
@colleenXu I believe I just fixed it, I'll get in a PR very soon. |
I've confirmed Rohan's suspicion that this bug came from biothings/bte_trapi_query_graph_handler#219. I locally reset to |
I confirmed that Rohan's PR fixes the example individual queries. I haven't tested a creative-mode query yet. I've also confirmed that the evidence_count fixes intended in biothings/bte_trapi_query_graph_handler#219 are still present. Examples from here Example 1 edge has evidence_count 56
Edge c6225b095f6e79ba23394fe1bc8e9549
Example 2 edge has evidence_count 80
edge
|
Noticed problems with other TRAPI edge-attributes sigh. Going to revert this issue's PR and semmeddb-text-snippet PRs, see #833 (comment) |
This comment was marked as duplicate.
This comment was marked as duplicate.
Example of TRAPI edge-attribute problem: Query
If you send this query to Automat-robokop, you get this edge. It has 3 diff edge-attributes that have the SAME attribute_type_id...for sentences, tmkp_confidence_score, tmkp_ids. (yes it's weird but that's what automat does)
But the equivalent edge in BTE CI is missing the tmkp_confidence_score and tmkp_ids edge-attributes
Note: Text-mined-targeted (through x-bte annotation) is fine. See same-info edge |
Closing this issue: addressed by reverting semmeddb text-snippet PRs. Also ended up reverting this issue's PR... |
Related to #880?Doesn't seem to be...Noticing multiple cases in 10/20 automated test run, where edge-attributes were duplicated.
Example query
ARAX-UI link
BTE raw response from https://bte.ci.transltr.io/v1/asyncquery_response/RTZGUYSS16
"39b1bb8612f44069718af35dfb771c96" from MolePro
"UNII:RWM8CCW8GP" affects "NCBIGene:5294"
Has 4 copies of this set of edge-attributes
"61028f688d7124cf8280bc1ef9abfcae" from Drug Approvals
"CHEBI:8378" applied_to_treat "MONDO:0015564"
Has 4 copies of this set of edge-attributes
Related TRAPI validation logs
The text was updated successfully, but these errors were encountered: