-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas support #53
Pandas support #53
Conversation
from tsdf import write_binary | ||
|
||
import pandas as pd | ||
from tsdf import read_tsdf, write_binary, TSDFMetadata | ||
|
||
def test_write_binary(shared_datadir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (and the referenced implementation write_binary.write_binary_file()
) should probably be renamed to rite_binary.write_numpy_to_binaries
, but this could be done later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some smaller suggestions for changes, but apart from that it all looks good.
Co-authored-by: Vedran Kasalica <[email protected]>
Co-authored-by: Vedran Kasalica <[email protected]>
Co-authored-by: Vedran Kasalica <[email protected]>
Co-authored-by: Vedran Kasalica <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the typing mistake.
Work in progress, not to be merged yet