Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas support #53

Merged
merged 12 commits into from
Jan 9, 2024
Merged

Pandas support #53

merged 12 commits into from
Jan 9, 2024

Conversation

kretep
Copy link
Member

@kretep kretep commented Nov 29, 2023

Work in progress, not to be merged yet

from tsdf import write_binary

import pandas as pd
from tsdf import read_tsdf, write_binary, TSDFMetadata

def test_write_binary(shared_datadir):
Copy link
Member

@vedran-kasalica vedran-kasalica Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and the referenced implementation write_binary.write_binary_file()) should probably be renamed to rite_binary.write_numpy_to_binaries, but this could be done later.

vedran-kasalica
vedran-kasalica previously approved these changes Jan 8, 2024
Copy link
Member

@vedran-kasalica vedran-kasalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some smaller suggestions for changes, but apart from that it all looks good.

Co-authored-by: Vedran Kasalica <[email protected]>
Copy link
Member

@vedran-kasalica vedran-kasalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the typing mistake.

@vedran-kasalica vedran-kasalica merged commit 44aa4b2 into main Jan 9, 2024
1 check passed
@vedran-kasalica vedran-kasalica deleted the pandas-support branch January 9, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants