Launch GHO on Avalanche #519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]>
* fix: Make new impl constant * fix: Fix AIP text
miguelmtzinf
reviewed
Nov 7, 2024
.gitmodules
Outdated
There was a problem hiding this comment.
do not add new dependencies, let's work with interfaces as much as we can
There was a problem hiding this comment.
Absolutely. I just added a PR comment so this doesn't get lost or "outdated" tag. I first will determine what is needed for testing, then will use mocks/interfaces instead of deps
miguelmtzinf
reviewed
Nov 7, 2024
| import {MiscArbitrum} from 'aave-address-book/MiscArbitrum.sol'; | ||
| import {IGhoToken} from 'gho-core/gho/interfaces/IGhoToken.sol'; | ||
|
|
||
| library Utils { |
There was a problem hiding this comment.
probably unneeded. We put everything in one single contract
There was a problem hiding this comment.
Removed in 5e07b5a
|
TODO: No new dependencies, create interfaces instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://governance.aave.com/t/arfc-launch-gho-on-avalanche-set-aci-as-emissions-manager-for-rewards/19339