improve connection to remote #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitc
commented
Feb 22, 2024
src/hackney_happy.erl
Outdated
| ?report_debug("happy eyeballs, try to connect using IPv6", [{hostname, Hostname}, {port, Port}]), | ||
| Self = self(), | ||
| Addrs = getaddrs(Hostname), | ||
| Pid = spawn_link( fun() -> try_connect(Addrs, Port, Opts, Self, {error, nxdomain}) end), |
There was a problem hiding this comment.
no need to spawn here, ,,either wya makes DNS resolution asynchronous.
|
I should provide a way to bypass DNS resolution and allows the user to force the way it wants to make a connection. Also allow them to choose the preference (for those that have to support the legacy with IPv4). |
This was referenced May 10, 2024
This was referenced Jun 19, 2024
ruslandoga
reviewed
Jun 19, 2024
| getaddrs(Hostname) -> | ||
| IP6Addrs = [{Addr, 'inet6'} || Addr <- getbyname(Hostname, 'aaaa')], | ||
| IP4Addrs = [{Addr, 'inet'} || Addr <- getbyname(Hostname, 'a')], | ||
| IP6Addrs ++ IP4Addrs. |
There was a problem hiding this comment.
👋 @benoitc
I wonder if it would make sense to "intersperse" the addresses here like [ipv6, ipv4, ipv6, ipv4, etc.]?
There was a problem hiding this comment.
This change implements the happy eyeballs strategy to bnring better support of IPv6 for hackney. It follows the recommendations iof the RFC 8305. https://datatracker.ietf.org/doc/html/rfc8305
This change allows hackney, to handle the no proxy environnement variable properly. This bbring real full support of proxy setup using environnement.
benoitc
force-pushed
the
happy_eyeballs
branch
from
75b8e72
to
bed3ae3
Compare
benoitc
force-pushed
the
happy_eyeballs
branch
from
062b285
to
420d855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pR track different changes to provide a better UX during connection to remote.