Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore empty proxy_env #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ignore empty proxy_env #739

wants to merge 1 commit into from

Conversation

feng19
Copy link

@feng19 feng19 commented Apr 28, 2024

When all_proxy= it will throw an error:

[error] GenServer #PID<0.2401.0> terminating
** (CaseClauseError) no case clause matching: []
    (hackney 1.20.1) deps/hackney/src/hackney_url.erl:248: :hackney_url.parse_netloc/2
    (hackney 1.20.1) deps/hackney/src/hackney.erl:691: :hackney.proxy_from_url/5
    (hackney 1.20.1) deps/hackney/src/hackney.erl:335: :hackney.request/5
    (tesla 1.8.0) lib/tesla/adapter/hackney.ex:75: Tesla.Adapter.Hackney.request/5
    (tesla 1.8.0) lib/tesla/adapter/hackney.ex:37: Tesla.Adapter.Hackney.call/2

@benoitc benoitc self-assigned this May 6, 2024
@benoitc
Copy link
Owner

benoitc commented May 10, 2024 •
edited
Loading

this should be merged in #737 . Working on it. Thanks for the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benoitc benoitc

Labels
working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feng19 @benoitc