fix: flickering selection outlines #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunderscore
force-pushed
the
preview-stability
branch
from
6adcf9a
to
7aa9740
Compare
Previously, we swapped between two proxy renderers in order to minimize the cost of building new game objects all the time, and to allow a new pipeline to build in parallel with rendering the prior pipeline. This worked, but caused flickering effects, due to the unity selection system being stateful and remembering the previously selected/highlighted instance ID. Here, we instead have a single primary proxy used for all rendering, and use alternate objects while setting up a shadow proxy pipeline. Closes: #453
bdunderscore
force-pushed
the
preview-stability
branch
from
7aa9740
to
bf41d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we swapped between two proxy renderers in order to minimize the cost of building new
game objects all the time, and to allow a new pipeline to build in parallel with rendering the
prior pipeline. This worked, but caused flickering effects, due to the unity selection system being
stateful and remembering the previously selected/highlighted instance ID.
Here, we instead have a single primary proxy used for all rendering, and use alternate objects
while setting up a shadow proxy pipeline.
Closes: #453