-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRAD2-2642: task is completed. #728
Changes from 7 commits
239065e
8734110
c012cb8
7218226
cc63875
477f426
517531f
c30eaa5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ public class GradStudentRecordPayload { | |
private String program; | ||
private String programCompletionDate; | ||
private String schoolOfRecord; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we get rid of schoolOfRecord? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, this is DTO EDX is using. We need a separate ticket to handle the changes in the shared interface between 2 systems. |
||
private String schoolOfRecordId; | ||
private String studentStatusCode; | ||
private String graduated; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,11 +15,13 @@ public class BatchGraduationStudentRecord { | |
private String program; | ||
private String programCompletionDate; | ||
private String schoolOfRecord; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we get rid of schoolOfRecord? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
private UUID schoolOfRecordId; | ||
|
||
public BatchGraduationStudentRecord(String program, Date programCompletionDate, String schoolOfRecord, UUID studentID) { | ||
public BatchGraduationStudentRecord(String program, Date programCompletionDate, String schoolOfRecord, UUID schoolOfRecordId, UUID studentID) { | ||
this.program = program; | ||
this.programCompletionDate = EducGradStudentApiUtils.formatDate(programCompletionDate, PROGRAM_COMPLETION_DATE_FORMAT); | ||
this.schoolOfRecord = schoolOfRecord; | ||
this.schoolOfRecordId = schoolOfRecordId; | ||
this.studentID = studentID; | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,8 @@ public class GraduationStudentRecordDistribution extends BaseModel{ | |
private String legalLastName; | ||
private String schoolOfRecord; | ||
private String schoolAtGrad; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we get rid of schoolOfRecord and schoolAtGrad? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
private UUID schoolOfRecordId; | ||
private UUID schoolAtGradId; | ||
private String programCompletionDate; | ||
private String honoursStanding; | ||
private String program; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use access token? We should try to get rid of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be handled in a new ticket.