GRAD2-2642: task is completed. #728
Conversation
GRAD2-2642: task is completed.
GRAD2-2642: more unit tests for coverage, and cleanup some comments.
GRAD2-2642: removed the unused codes.
…w codes. GRAD2-2642: fixed the broken unit test to get more coverage on the new codes.
GRAD2-2642: more coverages on the new codes.
GRAD2-2642: more coverages on the new codes.
More coverages.
| logger.debug("getSchoolReportDataForYearEndNonGrad :"); | ||
| return response.GET(gradStudentReportService.getGradDistrictsForNonGradYearEndReport()); | ||
| return response.GET(gradStudentReportService.getGradDistrictsForNonGradYearEndReport(accessToken.replace(BEARER, ""))); |
There was a problem hiding this comment.
Why use access token? We should try to get rid of these
There was a problem hiding this comment.
This can be handled in a new ticket.
| @@ -12,6 +12,7 @@ public class GradStudentRecordPayload { | |||
| private String program; | |||
| private String programCompletionDate; | |||
| private String schoolOfRecord; | |||
There was a problem hiding this comment.
Can we get rid of schoolOfRecord?
There was a problem hiding this comment.
No, this is DTO EDX is using. We need a separate ticket to handle the changes in the shared interface between 2 systems.
| @@ -15,11 +15,13 @@ public class BatchGraduationStudentRecord { | |||
| private String program; | |||
| private String programCompletionDate; | |||
| private String schoolOfRecord; | |||
There was a problem hiding this comment.
Can we get rid of schoolOfRecord?
| @@ -19,6 +19,8 @@ public class GraduationStudentRecordDistribution extends BaseModel{ | |||
| private String legalLastName; | |||
| private String schoolOfRecord; | |||
| private String schoolAtGrad; | |||
There was a problem hiding this comment.
Can we get rid of schoolOfRecord and schoolAtGrad?
| @@ -18,4 +19,7 @@ public class ReportGradSchoolYearEndEntity implements Serializable { | |||
| @Column(name = "MINCODE") | |||
There was a problem hiding this comment.
can we get rid of mincode?
| return getWebClient().get() | ||
| .uri(String.format(getConstants().getSchoolsByDistrictIdUrl(), districtId)) | ||
| .headers(h -> { | ||
| h.setBearerAuth(accessToken); |
There was a problem hiding this comment.
we shouldn't be using access token anymore
There was a problem hiding this comment.
This can be handled in a new ticket.
| } | ||
|
|
||
| public List<ReportGradStudentData> getGradStudentDataForNonGradYearEndReportByDistrict(UUID districtId) { | ||
| PageRequest nextPage = PageRequest.of(0, PAGE_SIZE); |
There was a problem hiding this comment.
If there are more than PAGE_SIZE they will never be included?
There was a problem hiding this comment.
Yes, it is retrieving students for one district, and that will be huge volume of data.
| COUNT(GRADUATION_STUDENT_RECORD_ID) STUD_NUM, | ||
| -- Revert code back to school of record GRAD2-2758 | ||
| --SUBSTR(DECODE(A1.SCHOOL_AT_GRADUATION, NULL, A1.SCHOOL_OF_RECORD, A1.SCHOOL_AT_GRADUATION), 0, 3) MINCODE | ||
| A1.SCHOOL_OF_RECORD MINCODE, |
There was a problem hiding this comment.
can we get rid of mincode?
Do we need to update REPORT_GRAD_DISTRICT_YE_VW as well?
There was a problem hiding this comment.
Mincode is removed from REPORT_GRAD_SCHOOL_YE_VW.
REPORT_GRAD_DISTRICT_YE_VW has been dropped.
… DTOs and Entities. GRAD2-2642: schoolOfRecord & schoolAtGraduation fields are removed in DTOs and Entities.
|
GRAD2-2642: task is completed.