Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

EMotionFX crash when used with replication #533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SecretsOTheP
Copy link

Issue #, if available: N/A

Description of changes: Fixes an uninitialized variable in an EmotionFX component. (m_animGraphInstance)

This variable will cause a crash, especially in a replicated situation where Activate is not called on this component - as it doesn't use a weak pointer container.

m_animGraphInstance needs to be set to null before being used - otherwise, the pointer will be considered valid memory as it's set to a non-null, garbage memory value by default.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes an uninitialized variable in an EmotionFX component. (m_animGraphInstance)

This variable will cause a crash, especially in a replicated situation where Activate is not called on this component - as it doesn't use a weak pointer container. m_animGraphInstance needs to be set to null before being used - otherwise, the pointer will be considered valid memory as it's set to a non-null, garbage memory value by default.
@AMZN-Gene
Copy link

Thanks for the fix! I’ll pass this to the character team for review :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants