bug: Set Step function log group prefix + fix deployment when not def… #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault embeded is set.
grinko
approved these changes
Oct 29, 2024
This was referenced Oct 29, 2024
|
@charles-marion please make this change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ault embeded is set.
Issue #, if available: #596
Description of changes:
In #596 , the Step function prevents deployment because the account has reach the number of policies. See here
https://docs.aws.amazon.com/step-functions/latest/dg/sfn-best-practices.html#bp-cwl
The fix is to set the prefix of the log group names (
/aws/vendedlogs/) so step function uses statement for all..In #592, the CDK synth fails when there is no default embedding model (only needed when using Aurora/Opensearch).
Removed the check (since it's a valid use case) and verified the Embedding page is still working without default model.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.